LOG-9386: fix(disk buffer): treat decode errors as bad reads during initialization seek - #289
LOG-9386: fix(disk buffer): treat decode errors as bad reads during initialization seek#289vparfonov wants to merge 1 commit into
Conversation
|
@vparfonov: This pull request references LOG-9386 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@vparfonov most of this PR is test code where my understanding of the logic is weak. Does adding this one error type the only thing that modifies the behavior from "crash" to "skip"? |
d881a1d to
d37b576
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
…nitialization seek Apply upstream PR vectordotdev#25691 with adjusted test naming. Add ReaderError::Decode to is_bad_read() so the reader skips the corrupted data file during initialization instead of failing with CrashLoop. Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
d37b576 to
99d76a9
Compare
|
/hold cancel |
3 participants
Apply upstream PR vectordotdev#25691 with adjusted test naming.
Add
ReaderError::Decodetois_bad_read()so the reader skips the corrupted data file during initialization instead of failing with CrashLoop.JIRA: https://redhat.atlassian.net/browse/LOG-9386
/assign @jcantrill